[LLVM] Fail if LLVM_ENABLE_ZSTD is FORCE_ON but static zstd libraries are not found
#15924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
|
@uditagarwal97, don't forget to update llvm/llvm-project#113584. |
Contributor
Author
Done. |
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
approved these changes
Oct 30, 2024
Contributor
Author
|
@intel/llvm-gatekeepers the PR is ready to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if we pass
LLVM_USE_STATIC_ZSTD=ONandLLVM_ENABLE_ZSTD=FORCE_ON, we silently ignore zstd and proceed to build the compiler.With
LLVM_ENABLE_ZSTD=FORCE_ON, we should throw an error instead.Thanks @tcreech-intel for find this.